[MPlayer-DOCS] Build system [patch]
Diego Biurrun
diego at biurrun.de
Wed Dec 24 23:16:43 CET 2003
Torinthiel writes:
> On Wed, Dec 24, 2003 at 08:08:05PM +0100, Diego Biurrun wrote:
> > Torinthiel writes:
> > I have some small suggestions below. Also please test it under Cygwin
> > as that was the original motivation for the build system change. If
> > you cannot test it yourself, send it to the mplayer-cygwin list,
> > somebody there should be able to help you out. I'd test it myself,
> > but I do not currently have access to a Windows box I can fiddle with.
>
> Ok, applied almost all, except for one. Sent here, and I will send it to
> -cygwin as soon as I subscribe it, as I don't use it. And I'll even
> subscribe (for a brief period of time) to -os2 and -users, to ask if
> anybody has a different DTD location. Is there a list for MinGW? I think
> I should also ask there.
mplayer-cygwin also covers MinGW.
> > > distclean:
> > > + rm -f main.xml
> >
> > That's unnecessary in Makefile.inc, it's already removed from within
> > Makefile upon distclean. Remove this.
>
> No, it is not the same main.xml file. There is one in xml directory,
> which contains LANG_CODE, and one in each language subdirectory that
> contains LANG_CODE sedded to appropriate code. And each one needs to be
> removed during make.
Oops, I overlooked that, sorry.
> Maybe I should rename the root file to something indicating it's
> not usable without changing, but I don't have any sensible
> idea. Anyway, this is only cosmetics.
template_main.xml sounds reasonable, but there should be a way to do
this directly without the intermediate template_main.xml. I'll leave
it as an exercise to the reader ;-)
Diego
More information about the MPlayer-DOCS
mailing list