[MPlayer-DOCS] Build system [patch]

[Diego Biurrun]

Torinthiel writes:
 > Ok, here is the newest wersion of my build system patch. It incudes
 > newest sync, so applies cleanly on todays CVS. And I get more info it is
 > needed - you place the DTD in
 > /usr/share/sgml/docbook/dtd/xml/4.1.2/docbookx.dtd,
 > on Cygwin it is in usr/share/docbook-xml42/docbookx.dtd,
 > on PLD in /usr/share/sgml/docbook/xml-dtd-4.1.2/docbookx.dtd,
 > on Gentoo in /usr/share/sgml/docbook/xml-dtd-4.1.2/docbookx.dtd
 > So it's getting more and more needed.
 > Please test and comment, I'll apply when it's acceptable.

I have some small suggestions below.  Also please test it under Cygwin
as that was the original motivation for the build system change.  If
you cannot test it yourself, send it to the mplayer-cygwin list,
somebody there should be able to help you out.  I'd test it myself,
but I do not currently have access to a Windows box I can fiddle with.

 > +main.xml: ../main.xml
 > +	@sed -e 's/xx/$(XML_LANG)/' ../main.xml>main.xml

Hmm, I think "xx" should be something a tad more descriptive,
"XML_LANG" sounds good to me.

Also please put some spaces around the ">", to make it more readable.

 >  distclean:
 > +	rm -f main.xml

That's unnecessary in Makefile.inc, it's already removed from within
Makefile upon distclean.  Remove this.

 > +  echo "Not found. Using default ($_dtd)"
 > +else
 > +  echo "Found docbookx.dtd at $_dtd"

Nit: Please put some colons "." at the end of these sentences.

 > +for file in `find en -name \*.xml -exec basename \{\} \;|sort`; do

Same as above here with the "|", please add some spaces for
readability.

Diego