[MPlayer-DOCS] Build system change - please test

Diego Biurrun diego at biurrun.de
Wed Dec 3 05:35:42 CET 2003


OK, I'll need some more time to review this, below are some trivial
preliminary comments.  It would be nice if you could redo the patch,
it does not apply cleanly atm.

Torinthiel writes:
 > The testing procedure I've used was keeping the old directory xml,
 > applying the patch in xml.new (which before the patch was an exact copy
 > of xml), and making it generealte files in *.new (second patch).
 > Afterwards making in both directories - in xml with symlinks, in xml.new
 > with symlinks deleted, and then diffing the results. The diff was LARGE,
 > but the only differences were in id* tags, so I've used a script (third
 > attachment) to remove all the id's (they were different even when
 > re-making with the same build system).

Hmm, why didn't you simply use two different checkouts?  I always have
one tree to mess with (readonly) and another that has the real changes
(readwrite).

 > --- configure	16 Nov 2003 00:57:47 -0000	1.8
 > +++ configure	26 Nov 2003 22:36:33 -0000
 > @@ -93,7 +93,41 @@
 >  </xsl:stylesheet>
 >  EOF
 >  
 > +echo "Searching for dtd..."

DTD should be uppercase.

 > --- en/Makefile	20 Oct 2003 09:56:43 -0000	1.3
 > +++ en/Makefile	26 Nov 2003 22:36:33 -0000
 > @@ -3,6 +3,9 @@
 >  # Set if you are using your own HTML stylesheet...
 >  #HTML_STYLESHEET = mystyle.css
 >  
 > +# Set to the xml language code of your language

XML should be uppercase, put a '.' at the end of each sentence.

Diego



More information about the MPlayer-DOCS mailing list