[MPlayer-dev-eng] lavcac3enc broken?

[eatdirt]

Woo! Thanks for looking at it.

Ok, it segfaults in av_helpers now

In gdb:

Starting playback...

Program received signal SIGFPE, Arithmetic exception.
0x0000555555744f2b in lavc_encode_audio (ctx=0x555555b78a40, 
src=0x555555d9f570, src_len=36864, dst=dst at entry=0x555555dbf528, 
dst_len=dst_len at entry=18432) at av_helpers.c:136
136	    frame->nb_samples = src_len / ctx->channels / bps;


(gdb) bt
#0  0x0000555555744f2b in lavc_encode_audio (ctx=0x555555b78a40, 
src=0x555555d9f570, src_len=36864, dst=dst at entry=0x555555dbf528, 
dst_len=dst_len at entry=18432) at av_helpers.c:136
#1  0x0000555555745802 in play (af=<optimized out>, data=<optimized 
out>) at libaf/af_lavcac3enc.c:244
#2  0x000055555567f416 in af_play (s=<optimized out>, data=<optimized 
out>, data at entry=0x7fffffffc630) at libaf/af.c:584
#3  0x000055555569161b in filter_n_bytes (len=130944, sh=0x555555b8c020) 
at libmpcodecs/dec_audio.c:423
#4  mp_decode_audio (sh_audio=sh_audio at entry=0x555555b8c020, 
minlen=minlen at entry=96000) at libmpcodecs/dec_audio.c:493
#5  0x00005555555e3a4a in fill_audio_out_buffers () at mplayer.c:2164
#6  main (argc=<optimized out>, argv=<optimized out>) at mplayer.c:3777


On 29/03/2023 19:38, Reimar Döffinger wrote:
> 
> 
>> On 29 Mar 2023, at 12:51, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
>>
>>>
>>> On 27 Mar 2023, at 17:37, eatdirt <eatdirt at protonmail.com> wrote:
>>>
>>> Hi there,
>>> I am a long term user of mplayer, and my "custom" usage is to reencode audio streams to ac3 to feed my "old" amplifier.
>>>
>>> Since version 1.5, it seems that the audio chain having:
>>>
>>> -af lavcac3enc 1:x:y
>>>
>>> is broken as soon as the stream is not ac3 (it used to work with any stream pre-version 1.5).
>>>
>>> Here the errors popping out, for instance from an eac3 audio channel:
>>>
>>> [ac3_fixed @ 0x7f72fd553760]Specified sample format s16p is invalid or not supported
>>
>> Seems there was a FFmpeg change making the ac3 encoder only support 32-bit input.
>> So the lavcac3enc code would need to be changed to take that instead of 16-bit inputs.
>> It should not be hard, but might take a bit of time to do.
> 
> Unfortunately I can't test it, but I have a patch attached...
> 
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng