[MPlayer-dev-eng] [PATCH] Have sndio check use the pkg-config file
Reimar.Doeffinger at gmx.de
Sun Mar 27 13:38:53 EEST 2022
> On 27 Feb 2022, at 23:46, Brad Smith <brad-at-comstyle.com at ffmpeg.org> wrote:
>> I think it might also cause issues with static linking.
>> So yes it would be better to change that.
>> Also why did you change from statement_check to header_check?
> I was copying what Pulse was doing, not being sure what was appropriate. Pulse has a library so it should
> be checking that as well I would think.
To be honest I think all the code here is bad, so the comments are more from a "no regressions" point.
It seems you can assume it is there on OpenBSD, but pkg-config often ends up not installed on Linux quite often, and sndio exists on Linux.
So I would normally suggest to add pkg-config only as a fallback option like for the JACK case you mentioned.
But I am aware that also has its issues, and you didn't say why you want this change (which I kind of also need to know for the commit message).
More information about the MPlayer-dev-eng