[MPlayer-dev-eng] [PATCH] Have sndio check use the pkg-config file

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Feb 27 10:58:55 EET 2022

> On 26 Feb 2022, at 22:49, Brad Smith <brad-at-comstyle.com at ffmpeg.org> wrote:
> Have the sndio check use the pkg-config file.
> BTW, looking at other examples to take inspiration for this I noticed the Pulse
> and JACK bits use libs_mplayer vs extra_ldflags and echores is higher up. Little
> inconsistencies are kind of annoying when looking at code to get an idea of how
> to do things.

Using extra_ldflags means mencoder will also link against it, which I suspect is not correct here?
I think it might also cause issues with static linking.
So yes it would be better to change that.
Also why did you change from statement_check to header_check?
That is not right since it will not test linking (and thus --libs for pkg_config makes no sense).
I am not familiar with sndio, is there a significant chance people might be using it without pkg-config file installed?

More information about the MPlayer-dev-eng mailing list