[MPlayer-dev-eng] [PATCH] Fix building with Clang
brad at comstyle.com
Fri Feb 18 04:29:01 EET 2022
On 2/17/2022 1:37 PM, Reimar Döffinger wrote:
>> On 23 Dec 2021, at 21:36, Brad Smith <brad at comstyle.com> wrote:
>>> It seems the problem might be your compiler defaulting to C++11, and in the future even newer C++ versions.
>>> So the real issue might be that this old code really should be compiled with -std=c++98 if that option is available?
>>> After all your change might fix the issue with C++11 compatibility, but who knows what other issues would pop up if the compiler tried to compile it as C++30 or whatever...
>>> That said I don't know if there is a point in keeping these mp_dbg macros at all.
>> I don't know but this was commited back when we brought in Clang 6 and still is an issue with Clang 13. Clang all the way back to 6 defaults to C++14.
> I changed configure to explicitly request c++98.
> But I am still curious in which situation this happens.
> Is this using live555? If so, that would be real useful to know about, for example any reason you can't use FFmpeg for your use-case? Or do you use patches to support a newer live555 version?
> Because I am considering if the best way forward is to remove all live555 code, so any info on real-world use would help make the right decision there.
To be honest our live555 is absolutely ancient. I haven't updated in
many moons. It's just enabled as
it is there. Looks like I have said support disabled in VLC as the
dependency is too old. Looks like the
last time I updated the port was just shy of 10 years ago. So it's as a
2012 version. Looking through
our ports tree the only ports that use this are MPlayer and VLC.
Looking at FreeBSD they have relatively new (2020) Livemedia but don't
have support enabled in MPlayer.
NetBSD has a version from 2014 and does not enable support in MPlayer.
I think I'm just going to go ahead and disable support for this.
More information about the MPlayer-dev-eng