[MPlayer-dev-eng] [PATCH] Allow user to choose strip program when configure

[Alexander Strasser]

Hi all,

On 2020-03-06 10:03 +0100, Reimar Döffinger wrote:
> On 8 February 2020 10:21:23 CET, ex0804992 at itri.org.tw wrote:
> >My mistake, resend the patch.
>
> My suggestion would be to default to empty for strip, and only append
> --strip-program if it's non-empty.
> That would adress both compatibility concerns and "install" variants clever enough to figure out the right strip command.

I have changed it, so the option is only appended if the --strip option
was given to configure.

Not sure this is the best way to solve this issue, but being able to
specify the strip program in general doesn't seem wrong to me anyway.

I suspect the FFmpeg build system, is a bit smarter about this and
uses the cross-strip via prefix when stripping binaries that were
cross-compiled. Not sure though, I didn't try.

The implementation now and before has some limitations regarding the
path of the strip program (e.g. space chars). I think we have those in
other places too. So maybe we can fix all of those problems at once in
the future, though it doesn't seem to be problem for our users so far.


> That said, I am a bit surprised, I thought the "strip" command could usually handle all ELF files, independent of architecture?
> Also, isn't it a bit unusual to run "make install" when cross-compiling?

I would guess one rather important use case is packaging.


> That said except for the compatibility concerns I'm not against this change.


  Alexander