[MPlayer-dev-eng] mplayer 1.4.0 release

[Reimar Döffinger]

On Sun, Apr 14, 2019 at 10:42:19AM +0200, Reimar Döffinger wrote:
> On Wed, Apr 03, 2019 at 09:25:12PM +0200, Erik Auerswald wrote:
> > Testing on my older notebook still running Ubuntu 14.04 I do not see
> > the same problems with -vo xv, but similar one when changing the
> > window size (but not in fullscreen mode).
>
> How do you manage to do that?
> MPlayer sets PAspect window hint, you are not supposed to be able to
> resize the window in a way that needs black borders, and vo_xv was not
> designed to handle that case...
> Due to that I am not even able to test on my systems...

The consequences are a bit unclear to me, and as this has always
worked like this I am not sure we should change it, but below
might work for adding support for this.

--- a/libvo/x11_common.c
+++ b/libvo/x11_common.c
@@ -2358,7 +2358,7 @@ void vo_xv_draw_colorkey(  int32_t x,  int32_t y,

   /* draw black bars if needed */
   /* TODO! move this to vo_x11_clearwindow_part() */
-  if ( vo_fs )
+  if ( aspect_scaling() )
   {
     XSetForeground( mDisplay, vo_gc, 0 );
     /* making non-overlap fills, requires 8 checks instead of 4 */