[MPlayer-dev-eng] mplayer 1.4.0 release

[Alexander Strasser]

On 2019-04-06 23:28 +0200, Erik Auerswald wrote:
> On 4/6/19 22:18, Alexander Strasser wrote:
> > On 2019-04-04 09:14 +0200, Erik Auerswald wrote:
> > > On Wed, Apr 03, 2019 at 11:51:58PM +0200, Alexander Strasser wrote:
> > >
> > > > I will have a look into the vo xv issues. Sounds like it could be
> > > > a regression.
> > >
> > > There have been just a few commits to vo_xv.c since the release of
> > > 1.3.0, but I did not see anything obviously problematic. An older commit
> > > pertained to setting the background color (according to the commit log),
> > > but I did not look at that patch. But then I do not know that code at all.
> > >
> > > It seems as if the borders are actually drawn, but not in black, but
> > > using some other memory contents, sometimes from the video, sometimes
> > > from the root window ("desktop"). It does not look as if unitialized
> > > memory is copied.
> > >
> > > Since the commits since 1.3.0 pertained to formats: on the 18.04 system
> > > MPlayer reports "VO: [xv] 1280x720 => 1280x720 Planar YV12".
> >
> > Did that line change compared to the version you didn't have the
> > border drawing problems?
>
> No, it did not.
>
> More data points:
>
> - Fullscreen black borders work with current SVN without an external
>   monitor connected (Ubuntu 18.04).
>
> - Maximising the video image results in wrong image content instead
>   of black bars with current SVN (all tested systems and
>   configurations).

It's a regression since r33522 (May 2011)

I suspect a debugging modification sneaked in. If I make the
following change, borders look fine again:

--- a/libvo/vo_xv.c
+++ b/libvo/vo_xv.c
@@ -139,7 +139,7 @@ static void deallocate_xvimage(int foo);
 static void resize(void)
 {
     calc_src_dst_rects(image_width, image_height, &src_rect, &dst_rect, NULL, NULL);
-//    vo_x11_clearwindow_part(mDisplay, vo_window, dst_rect.width, dst_rect.height, vo_fs);
+    vo_x11_clearwindow_part(mDisplay, vo_window, dst_rect.width, dst_rect.height, vo_fs);
     vo_xv_draw_colorkey(dst_rect.left, dst_rect.top, dst_rect.width, dst_rect.height);
 }


Maybe Ivan can confirm?


  Alexander