[MPlayer-dev-eng] [PATCH] haiku support
Reimar.Doeffinger at gmx.de
Sun Sep 10 16:57:07 EEST 2017
On 08.09.2017, at 08:10, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> On 02.09.2017, at 22:28, Compn <tempn at mi.rr.com> wrote:
>> patch looks ok to me.
>> maintained by miqlas.
>> any haiku users out there? :)
> Some of the files lack license headers, I don't think the ao/vo modules should be enabled unconditionally,
> the libraries should be linked against depending on enabed modules, not depending on OS,
> the header include guards don't have the right format (especially should not start with _),
> several files miss license headers (and I don't like the MIT license one either, because then I have to check of it's compatible with GPL, plus the actual license needs to be included as well).
I now checked, unfortunately the are quite a few "MIT" licenses, and some few of those are actually GPL-incompatible (contain advertising clause).
So I'm afraid the licensing needs to be clarified before we can add it, otherwise distributions like Debian will be mad at us...
More information about the MPlayer-dev-eng