[MPlayer-dev-eng] [PATCH] demux lavf: mp_read: Propagate EOF
Alexander Strasser
eclipse7 at gmx.net
Fri Nov 17 01:27:09 EET 2017
On 2017-11-17 00:06 +0100, Alexander Strasser wrote:
> Hi,
>
> thank you for having a look at this Michael and Nicolas!
>
> On 2017-11-16 22:24 +0100, Michael Niedermayer wrote:
> > On Sun, Nov 12, 2017 at 10:16:52PM +0100, Alexander Strasser wrote:
> > > Return AVERROR_EOF from mp_read callback, if stream->eof is non-zero.
> > >
> > > Fixes ticket #2335
> > >
> > > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > > ---
> > >
> > > Please look at the ticket for more details.
> > >
> > > Although there was a patch committed in FFmpeg, that avoids
> > > the problem for now, I don't want to wait until the next bump
> > > re-introduces the problem.
> > >
> > > libmpdemux/demux_lavf.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > LGTM
>
> Committed.
>
>
> > maybe the mp_msg() should be changed so it displays EOF insteda of
> > the decimal value but thats rather very minor
>
> I agree on that, but as the fix is rather important I didn't want to
> wait any longer. At least one can see if EOF is returned by spotting
> large negative decimal values.
Sorry, rather important was maybe a bit to strong here. I just
temporarily forgot that the problem was mitigated in FFmpeg.
So I hope not many people are experiencing the hangs that happened
for some FFmpeg revisions when seeking.
>
>
> [...]
Alexander
More information about the MPlayer-dev-eng
mailing list