[MPlayer-dev-eng] Probable boolean logic bug

[Ivan Kalvachev]

On 6/21/17, Alexander Strasser <eclipse7 at gmx.net> wrote:
> Hi Michael!
>
> On 2016-04-16 17:16 -0400, Michael McConville wrote:
>> It seems that there's a nonsensical if condition in the IVTV code. It
>> always evaluates to true because it tests the same variable against
>> multiple different constants. The most probable explanation is that ||
>> was used when && was intended.
>
> This particular problem was fixed by Reimar in ao v4l2 already,
> which is AFAICT directly derived from ao ivtv, but ao v4l2 should
> be the one to use nowadays.
>
> AFAIU ivtv interface was there before this stuff was possible with
> video4linux, but the interfaces were afterwards integrated into video4linux
> and ivtv should not be relevant since like about a decode ago. I am
> no expert in this area, but I guess we should consider to completely
> drop ivtv support in MPlayer.

I just want to point out that long time ago the ivtv driver code
got merged into the kernel, but with slightly different API,
that broke MPlayer compilation. I added the breakage into
the ivtv configure test.
r25946

What I'm saying is that ivtv check never succeeded for
almost a decade and this code has effectively
been disabled during all this time.