[MPlayer-dev-eng] how to add lookup / add functions in loader/win32.c ?

[Reimar Döffinger]

On Sat, May 16, 2015 at 06:27:16PM -0400, compn wrote:
> any loader devs still around want to clean up and finish this? :)

I'd doubt it, so I'll just add a few comments.

> +static int exp_encode_pointer(void *ptr)
> +{
> +    dbgprintf("_encode_pointer (0x%08x)\n", ptr);
> +    return 0;
> +}

Should probably just be added anywhere we have
exp_decode_pointer already

> +static const struct exports exp_atl90[]={
> +    FF(_initterm_e, -1)
> +    FF(_initterm, -1)
> +    FF(memset,-1)
> +};

Considering they are in MSVCRT I don't think they
should be here.
Also by the messages only numerical exports are used
(i.e. the thing after the comma where you have all -1s).
Unfortunately I can't even figure out what atl90.dll actually is...

> @@ -5635,6 +5675,80 @@
>      {"??3 at YAXPAX@Z", -1, expdelete}
>  };
>  
> +static const struct exports exp_msvcr90[]={

All needed?
I wonder if instead of having different variants
for all versions (msvcrt, msvcr80, msvcr100) if it
wasn't possible to do just one that works for all...