[MPlayer-dev-eng] [PATCH] mplayer: add the -ass-keep-fonts option.

[Alexander Strasser]

On 2015-03-01 21:20 +0100, Hans-Dieter Kosch wrote:
> Nicolas George wrote:
> 
> >Le primidi 11 ventôse, an CCXXIII, Hans-Dieter Kosch a écrit :
> >>Ingo Brückl wrote:
> >>>-ass-reuse-fonts?
> >
> >I slightly prefer "keep" because I have a feeling it describes better what
> >happens: MPlayer keeps the font in memory, whether it will actually use it
> >again or not. But I am not a native English speaker, and maybe I am mapping
> >French nuances on the corresponding English words.
> >
> >More objectively, "keep" is a more common word, so people will remember more
> >easily.
> 
> I understand a bit of French (but regrettably too less). From that point of
> view, "keep" appears now the word of choice for me.
> 
> >>That appears to describe the effect of this option quite well.
> >>Or, even more precise:
> >>-ass-reuse-fonts-from-first-file
> >>-ass-reuse-fonts-from-first-stream
> >>or alternatively
> >>-ass-keep-fonts-from-first-file
> >>-ass-keep-fonts-from-first-stream
> >
> >This would not do, because the patch as it is keeps the fonts from all the
> >files, not just the first one. It is easy to see by just looking at the
> >code: the option inhibits the reset that happens between the files.
> >
> >-ass-keep-fonts-between-files would do, but I find it uselessly long.
> 
> After a closer look, I understand now. Anyway,
> "-ass-keep-fonts-between-files" does not appear too long for me (I've seen
> longer options).
> 
> Or even longer:
> -ass-keep-fonts-for-subsequent-files

  I am also fine with one of the above mentioned names (repeated below ;)

  -ass-keep-fonts-between-files
  -ass-keep-fonts-for-subsequent-files

or just

  -ass-keep-fonts

  IMHO this is such a specific option for rather special use cases
that there is no way to name it such that it would be crystal clear
to a random person reading it the first time.

  And for those kind of expert options it is more important to have
it in the man page with a precise and clear description and IMHO this
is achieved in the patch. It is also important to me thah the feature
is turned off by default, which again it is in the submitted patch.

  So LGTM. Please choose the name you prefer Nicolas and commit if
no more comments arrive.

> (Appropriate naming may be a nightmare, I know...)

  Agreed.

  I thought about using something with "cache" in the name. But
then tought it would be rather more confusing, because as a user
reading a name like -ass-cache-fonts it sounds like it should be
turned on by default.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20150302/b1314eb8/attachment.asc>