[MPlayer-dev-eng] [PATCH] Fix spelling errors found by lintian.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jul 15 21:24:02 CEST 2015


On Mon, Jul 13, 2015 at 04:22:07AM -0400, Miguel A. Colón Vélez wrote:
> >   Nice, some packaging efforts. I did some experiments for
> > that too last year, but did not have much time to work on it.
> > I will try to dig up the findings from that time.
> 
> I have a package for it working but it's waiting for the FFmpeg transition.
> http://anonscm.debian.org/cgit/pkg-multimedia/mplayer.git/tree/?h=master.experimental
> 
> Not sure if it's the right place to ask but is there a reason for not
> including "libavutil/x86/asm.h" somewhere in the subversion? This
> FFmpeg file seems to be the only one needed for a successful
> compilation with a shared FFmpeg library. It seems to be a private
> header and therefore not included in Debian's or any other Linux
> distros (that I know of). It's used in:

I do not mind that much, it's just that it would be effort to maintain.
If you were to volunteer to from time to time update (or remind someone
to update) it if it's changed in FFmpeg then I'd not even have a minor
objection left :)

> The genres table seems to just translate that number into something
> the user would understand when displayed. The typo seems to have been
> left as is because as explained in the comment "typo taken from the
> id3v2spec". That comment was not part of the original id3edit source
> (from 2002) so I assumed that was the reason the typo was left
> unchanged and that is why I mentioned it was fixed in the latest
> id3v2spec.

If the spec was updated, I guess it is fine to change.
I don't know how relevant staying in sync with upstream is,
probably not much.
I'd be very, very slightly in favour of changing them just to
shut up the warnings as we'll probably never again sync
with upstream but if others have opinions otherwise I will
concede.


More information about the MPlayer-dev-eng mailing list