[MPlayer-dev-eng] mpcommon.c + bug +review

[Reimar Döffinger]

On Tue, Apr 28, 2015 at 05:56:15AM +0000, Hainan Ren (任海男) wrote:
> hi,
> 
> when i get some src codes ,i  want to figure how mplayer decode the mp3 format audio and play it,
> 
> then i find a bug,which i sincerely think so.
> 
> 
>             mpcommon.c
> 
>                     ​calc_a_pts
> 
> line 551            a_pts = sh_audio->ptr;
> 
> 
> the there is obviously  not a ptr member in sh_audio ,which i think maybe it comes from d_audio

Not sure what version that was or where it came from,
but there is no such line in the code.
The line that actually is in the code looks like this and works:
a_pts = sh_audio->pts;
Assuming you did not modify the file by accident, it might be
time to check your hardware for errors.
(a single bit-flip could convert the s to an r)