[MPlayer-dev-eng] [PATCH 1/2] Pass application/vnd.ms-opentype attachments to libass

Nicolas George george at nsup.org
Sat Oct 25 13:42:33 CEST 2014


Le quartidi 4 brumaire, an CCXXIII, Alexander Strasser a écrit :
> Make those font attachments work with at least demux_mkv.
> 
> Fix part of ticket 2207
> Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> ---
>  mplayer.c | 1 +
>  1 file changed, 1 insertion(+)

I think this is a good idea.

> 
> diff --git a/mplayer.c b/mplayer.c
> index 6a32e88..482bf53 100644
> --- a/mplayer.c
> +++ b/mplayer.c
> @@ -3436,6 +3436,7 @@ goto_enable_cache:
>              if (extract_embedded_fonts &&
>                  att->name && att->type && att->data && att->data_size &&
>                  (strcmp(att->type, "application/x-truetype-font") == 0 ||

> +                 strcmp(att->type, "application/vnd.ms-opentype") == 0 ||

This one seems widely used, especially by mkvmerge, so it must be there.

But while you are at it, maybe add the official MIME type for OpenType and
other fonts, i.e. application/font-sfnt.

>                   strcmp(att->type, "application/x-font") == 0))
>                  ass_add_font(ass_library, att->name, att->data, att->data_size);
>          }
> -- 

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20141025/5e123e86/attachment.asc>


More information about the MPlayer-dev-eng mailing list