[MPlayer-dev-eng] [patch] RT subtitle timestamp parsing buggy

[Reimar Döffinger]

On Sun, May 25, 2014 at 03:08:08AM +0200, Clément Bœsch wrote:
> On Sat, May 24, 2014 at 08:05:00PM +0200, Reimar Döffinger wrote:
> > On Fri, Mar 21, 2014 at 05:16:35PM +0200, hhaamu at gmail.com wrote:
> > > 1) sscanf sets a1, a2 etc even when the whole line does not match. The
> > > lines that try to parse begin/end tags will partially match and set
> > > those variables, leading to faulty timestamps. The variables should be
> > > reset to zero after each match attempt.
> > 
> > That whole code is seriously horrible and scary.
> 
> RT is supported in FFmpeg if you want to replace it. I think mpv switched
> to them somehow.

Well, I think it should be possible to use even now with some -sub-demuxer or
so hacks, though it's been a long time since I worked on it.
I think it doesn't work together with the -dump* options for subtitles
since that one requires all subtitles to be read into memory at once,
which we currently don't do when we use FFmpeg's code...
Though I am certainly misremembering some details.