[MPlayer-dev-eng] [PATCH] GUI: Potmeter button corrections

Ingo Brückl ib at wupperonline.de
Wed Mar 26 15:00:25 CET 2014

Hans-Dieter Kosch wrote on Wed, 26 Mar 2014 01:05:27 +0100:

> Ingo Brückl wrote:

>> This will go beyond the boundaries, resulting in an uiEvent() call with an
>> illegal value.

> You're right. I missed that. There's no value range check like in 'case
> wsMoveMouse:'

In this case value will always remain within the limits (which isn't true for
the mouse move).

> (nevertheless, I noticed exactly the expected behaviour, though (?) ).

btnModify() (called prior to rendering) finally restricts value.

> The mouse position yields an item value, and then in turn, the item value
> yields an object position. If the forward and reverse calculations differ,
> arbitrarily wierd displays can result.

Currently we actually have: mouse position -> value (which is decisive) ->
item representation (by rendering).

I'm aware that there may be precision problems when using a potmeter to
adjust something, but so far this didn't cause major troubles.

> PS: The rpotmeter is working now at least for the GTK GUI (I have still
> nothing to test Win32).

Don't spend too much time dealing with Win32. I can do the tests, and we can
even implement it for Win32 later (though I'd like to implement at one go).


More information about the MPlayer-dev-eng mailing list