[MPlayer-dev-eng] Is there a bug with balance?

[Ingo Brückl]

Hans-Dieter Kosch wrote on Sat, 22 Mar 2014 23:11:34 +0100:

> Ingo Brückl wrote:

>> Hans-Dieter Kosch wrote on Sat, 22 Mar 2014 03:47:51 +0100:
>>
>>> When running the GUI, balance is reset to 50% upon each new stream. Root
>>> cause is that mixer_getbalance() in mixer.c fails at first time and
>>> returns a default value of 0, interpreted as 50%.
>>>
>> Define "fails".

> In mixer_getbalance(), af_control_any_rev() returns NULL, meaning it
> couldn't get the balance (but this return value is not respected).

If there is no afilter or if no afilter is accepting the command, a default
balance of 0 (meaning 50%) is returned. Seems reasonable to me.

>> We should not rely on side effects, but 50% upon each new stream doesn't
>> look like a problem to me.

> It's annoying when playing a playlist if balance is reset with each next
> track (but that's off topic here...).

I've put it on my list under "what settings shouldn't be reset with a new
playback" (where already some entries are).

Ingo