[MPlayer-dev-eng] [PATCH] Add support for default of multiple video tracks

[Reimar Döffinger]

On 28 January 2014 00:09:40 CET, "Ingo Brückl" <ib at wupperonline.de> wrote:
>Reimar Döffinger wrote on Mon, 27 Jan 2014 23:55:42 +0100:
>
>> On 27.01.2014, at 21:55, Ingo Brückl <ib at wupperonline.de> wrote:
>>> I wrote on Mon, 27 Jan 2014 19:20:07 +0100:
>>>
>>> The mplayer.c part of the patch attached to this posting doesn't
>change
>>> video_id which is preferable.
>
>> This doesn't seem right/make sense to me.
>> The stream selection code if I remember right is in the code that
>adds a
>> new stream.
>
>Well, it doesn't seem to work then.

I expressed myself badly. The stream selection itself is there.
No code for handling default streams. But trying to do it there should make issues obvious.

>Could you please point to the code (file / function) where this should
>happen?

demuxer.c the code adding streams.
The issue is, that when we get a new stream we must immediately decide to play it or not, otherwise we might lose data.
But that means when a default stream comes later, you actually have to _switch_ streams, discarding data, reinitializing decoders, ...
And this might not be desirable anyway.
One way to solve this is to forget about doing it correctly but instead only fix the simple cases while making sure not to make the complex ones worse.
That can be done by making sure the demuxer creates all default streams it knows about from the start first.