[MPlayer-dev-eng] [PATCH] mplayer: minor fix for cinepak decoding

u-2w2r at aetey.se u-2w2r at aetey.se
Mon Jan 27 15:49:49 CET 2014


On Mon, Jan 27, 2014 at 09:25:21AM -0500, compn wrote:
> > the codec is interfacing now in RGB in accordance with its design.
> > 
> > Thus, the reference to YV12 in etc/codecs.conf is erroneous
> > and misleading.
> > 
> > ----
> > --- etc/codecs.conf.ori 2014-01-26 20:22:34.111641284 +0100
> > +++ etc/codecs.conf     2014-01-26 20:22:04.591296247 +0100
> > @@ -1009,7 +1009,7 @@
> >    fourcc cvid,CVID
> >    driver ffmpeg
> >    dll "cinepak"
> > -  out RGB24,YV12,BGR8 query
> > +  out RGB24,BGR8 query
> 
> looks ok if ffmpeg cinepak decoder does not output yv12.

It does not (it was me who fixed the former questionable format usage
in the decoder so I feel qualified to say this).

> also should remove 'query' while we are at it, query is a binary codec
> flag iirc.

Sure (yes the documentation states the flag is only relevant for old binary
codecs - but I was unsure as I did not check how it is possibly used).

Regards,
Rl



More information about the MPlayer-dev-eng mailing list