[MPlayer-dev-eng] [PATCH] configure: disable internal libmpeg2 by default.

[Brad Smith]

On 25/01/14 12:11 PM, Reimar Döffinger wrote:
> While the last tests showed that it can be slightly
> faster in some cases, the difference should not be
> relevant to the majority of users.
> In addition, the code is of not particularly high
> quality, so I consider it better/safer to have it
> disabled by default.
> I also welcome opinions on whether we should remove
> it completely (some time after the next release,
> whenever that might be).

I'd be fine with this. The OpenBSD package has been
shipping with libmpeg2 disabled for 2 1/2 years now.

> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 2eba2c0..207a566 100755
> --- a/configure
> +++ b/configure
> @@ -437,7 +437,7 @@ Codecs:
>     --enable-libdca           enable libdca support [autodetect]
>     --disable-liba52          disable liba52 [autodetect]
>     --disable-libmpeg2        disable libmpeg2 [autodetect]
> -  --disable-libmpeg2-internal disable builtin libmpeg2 [autodetect]
> +  --enable-libmpeg2-internal enable builtin libmpeg2 [disabled]
>     --enable-musepack         enable libmpcdec support (deprecated in favour of libavcodec) [disabled]
>     --disable-libopencore_amrnb disable libopencore_amr narrowband [autodetect]
>     --disable-libopencore_amrwb disable libopencore_amr wideband [autodetect]
> @@ -726,7 +726,7 @@ _mpg123=auto
>   _liba52=auto
>   _libdca=auto
>   _libmpeg2=auto
> -_libmpeg2_internal=auto
> +_libmpeg2_internal=no
>   _faad=auto
>   _faac=auto
>   _faac_lavc=auto
>


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.