[MPlayer-dev-eng] [PATCH] Do not use non-literal arguments for mp_msg format string

Alexander Strasser eclipse7 at gmx.net
Sun Jan 26 05:21:22 CET 2014


On 2014-01-26 02:16 +0100, Ingo Brückl wrote:
> Alexander Strasser wrote on Sun, 26 Jan 2014 01:30:17 +0100:
> 
> > diff --git a/gui/interface.c b/gui/interface.c
> > index 6e2387e..fdd6db4 100644
> > --- a/gui/interface.c
> > +++ b/gui/interface.c
> > @@ -1183,7 +1183,7 @@ void gmp_msg(int mod, int lev, const char *format, ...)
> >      vsnprintf(msg, sizeof(msg), format, va);
> >      va_end(va);
> >
> > -    mp_msg(mod, lev, msg);
> > +    mp_msg(mod, lev, "%s", msg);
> 
> Sure!

  OK, thanks for having a look!

> BTW, although ticket #2173 has been assigned component GUI, I neither have
> got an email notification nor does it show up under my tickets, because I'm
> not the (default) owner.

  I will look into what needs to be activated so you get email
notification.
  
  Though in this case I think it is actually assigned to the
wrong component. I wanted to change the component to something
else but discovered we miss a fitting component choice for that.
Maybe "undetermined" should be added.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140126/304eeb92/attachment.asc>


More information about the MPlayer-dev-eng mailing list