[MPlayer-dev-eng] [PATCH] configure: disable internal libmpeg2 by default.

[Alexander Strasser]

On 2014-01-25 18:11 +0100, Reimar Döffinger wrote:
> While the last tests showed that it can be slightly
> faster in some cases, the difference should not be
> relevant to the majority of users.
> In addition, the code is of not particularly high
> quality, so I consider it better/safer to have it
> disabled by default.

  I agree disabling by default is better. Though
quality is a kind of multi-dimensional metric.

> I also welcome opinions on whether we should remove
> it completely (some time after the next release,
> whenever that might be).

  Removing it after the next release in preparation
to the release following the next one seems OK to me.
That is if it does not compile anymore and no one cares
to fix.

> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 2eba2c0..207a566 100755
> --- a/configure
> +++ b/configure
> @@ -437,7 +437,7 @@ Codecs:
>    --enable-libdca           enable libdca support [autodetect]
>    --disable-liba52          disable liba52 [autodetect]
>    --disable-libmpeg2        disable libmpeg2 [autodetect]
> -  --disable-libmpeg2-internal disable builtin libmpeg2 [autodetect]
> +  --enable-libmpeg2-internal enable builtin libmpeg2 [disabled]
>    --enable-musepack         enable libmpcdec support (deprecated in favour of libavcodec) [disabled]
>    --disable-libopencore_amrnb disable libopencore_amr narrowband [autodetect]
>    --disable-libopencore_amrwb disable libopencore_amr wideband [autodetect]
> @@ -726,7 +726,7 @@ _mpg123=auto
>  _liba52=auto
>  _libdca=auto
>  _libmpeg2=auto
> -_libmpeg2_internal=auto
> +_libmpeg2_internal=no
>  _faad=auto
>  _faac=auto
>  _faac_lavc=auto

  LGTM if tested.


  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140126/53c9a584/attachment.asc>