[MPlayer-dev-eng] [PATCH] VOCTRL_GUISUPPORT

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 25 Feb 2014 17:49:26 +0100:

> On 25 February 2014 12:47:20 CET, "Ingo Brückl" <ib at wupperonline.de> wrote:
>>I'm not quite sure what exactly qualifies a driver for the VOCTRL_GUISUPPORT
>>to return VO_TRUE, but there seem to be X11 related drivers that currently
>>don't support this control:
>>
>>  3dfx
>>  dga
>>  dxr2
>>  sdl
>>  xmga
>>
>>Is it OK to add VOCTRL_GUISUPPORT? All VO_TRUE or anyone VO_FALSE?

> I'm not sure I remember correctly, but I think it should really signal
> support for reusing the GUI window which basically should be equivalent
> to -wid support nowadays.
> Which makes me think d3d vo sets it wrong...
> I think xmga should return true, for SDL depends on OS and no clue about
> the rest...

Here is what I've worked out.

mga_template: The defined(CONFIG_GUI) seems unnecessary. No other vo does it.

vo_dfbmga: VOCTRL_GUISUPPORT seems wrong.

vo_direct3d/vo_directx: Lack of VOCTRL_GUISUPPORT seems wrong.

vo_dxr2: VOCTRL_GUISUPPORT seems to depend on sub_vo.

vo_dxr3: VOCTRL_GUISUPPORT seems to depend on dxr3_overlay.

vo_sdl: VOCTRL_GUISUPPORT seems to depend on priv->X.

Unfortunately, I can't test other than vo_direct3d/vo_directx which I'm sure
about.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: guisupport.patch
Type: text/x-diff
Size: 2951 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140227/139c3b8e/attachment.bin>