[MPlayer-dev-eng] [PATCH] configure: add support for specifying a branch to use.

[Alexander Strasser]

On 2014-02-26 19:23 +0100, Reimar Döffinger wrote:
> On Wed, Feb 26, 2014 at 12:22:06AM +0100, Alexander Strasser wrote:
> > On 2014-02-24 20:18 +0100, Reimar Döffinger wrote:
> > > This is intended for use in release.
> > > ---
> > >  configure | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/configure b/configure
> > > index fab56a7..1448a23 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -1507,9 +1507,12 @@ if test -e ffmpeg/.svn ; then
> > >      exit 1
> > >  fi
> > >  
> > > +FFBRANCH=master
> > 
> >   I would prefer the name FFREF (or FFMPEG_REF) to address
> > the fact that we can use tag names too, which we IMHO should
> > do for release tarballs.
> 
> As you noticed that won't work without making quite a mess out
> of configure.
> In addition that is exactly what I do _not_ want to happen,
> someone downloading the tarball and getting a FFmpeg with
> month old security issues.
> A hard-coded tag is an equally horrible idea as including
> FFmpeg since it essentially means we should upload a new tarball
> for every security fix in FFmpeg.
> That was a huge mistake I very much don't want to repeat.

  Makes sense to me. Please discard my comment about it.
Seems I got the wrong idea with what exactly you wanted
to accomplish. So for just switching onto a release branch
it should be fine.

> >   BTW talking about releases, I guess we will make one soon,
> > won't we?
> 
> I'd hope so, preferably mostly in sync with FFmpeg 2.2, but Seems I
> got the wrong idea with what exactly you wanted
to accomplish. So for just switching onto a release branch
it should be fine.
> am not sure I'll make it.
> In particular since I think we really should update libass for the
> release.
> But if someone else wants to...
> 
> > > +test -e FFBRANCH && FFBRANCH=`cat FFBRANCH`
> > 
> >   I think we use $() instead of `` nowadays. A quick glance
> > at configure seems to support that suspicion.
> 
> Yes, I realized that shortly after I sent the patch.

  I am happy with the new patch you sent.

  Alexander

[...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140226/4cfa4a21/attachment.asc>