[MPlayer-dev-eng] [MPlayer-cvslog] [PATCH] GCC: Do not warn about unused paramters (was Re: r36944 - in trunk/gui/win

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Feb 26 19:15:52 CET 2014


On Wed, Feb 26, 2014 at 04:05:54PM +0100, Ingo Brückl wrote:
> And for the mentioned callback functions something like mp_unused() would
> indicate that not all of the parameters are relevant in this particular case
> (while allowing the usage of -Wunused-parameter).

I think you never commented on my suggestion to just remove or comment
out the argument in that case.
Which I think is exactly why the attribute behaves this way since
1) If it is an argument that is unused, you remove/comment out the name
2) If it's a variable, you just remove it
which leaves the one thing I believe the attribute is intended for
3) It may or may not be used and you want to avoid an ifdef-mess...


More information about the MPlayer-dev-eng mailing list