[MPlayer-dev-eng] [PATCH] Don't unnecessarily stop Win32 GUI playback

[Ingo Brückl]

Stephen Sheldon wrote on Mon, 24 Feb 2014 10:34:25 -0800:

> On 2/24/2014 10:08 AM, Ingo Brückl wrote:
>> Stephen Sheldon wrote on Tue, 11 Feb 2014 19:41:12 -0800:
>>
>>> On 2/11/2014 4:10 PM, Ingo Brückl wrote:
>>>> Stephen Sheldon wrote on Tue, 11 Feb 2014 11:26:16 -0800:
>>>>
>>>>>> Please start with your usual drivers. Then change both video and audio
>>>>>> while playing and start playing a new video. Now the new video does not
>>>>>> play.
>>>>> Correct.
>>>> Well, I'm not a Windows programmer, but the current code seems to be
>>>> nonsense. Please try the patch.
>>>>
>>> I am still getting the same symptom of the video not playing when I
>>> change both drivers at once.
>> It seems that my MinGW Windows 98 build allows changing both drivers if win32
>> sound isn't involved, i.e. as long as you keep your hands off win32 audio, it
>> seems to work (supposably the win32 driver is to blame).
>>
>> Could you please patch and check?
>>
> My audio choices are dsound, win32, null, pcm, mpegpes.

Same with me.

> I switched between directx, direct3d, gl, win32, null, and even pcm,
> changing both drivers at once, and the video played. This is with r36931.
> The video did not play if I changed both drivers and switched to or from
> win32 audio.

Same with me, too. (But at times I could change from or to win32 audio.)

I cannot see any more major bugs in the Win32 GUI prefences dialog, so I'd
blame the win32 audio driver.

Ingo