[MPlayer-dev-eng] Unable to detect/play H264-ES

[Reimar Döffinger]

On Wed, Feb 19, 2014 at 09:38:12PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Wed, 19 Feb 2014 21:25:27 +0100:
> 
> > On 19.02.2014, at 20:52, Ingo Brückl <ib at wupperonline.de> wrote:
> 
> >> I wrote on Tue, 18 Feb 2014 14:14:09 +0100:
> >>
> >>> Carl Eugen Hoyos wrote on Tue, 18 Feb 2014 11:58:38 +0000 (UTC):
> >>
> >>>> Josh <joshf87 <at> live.com> writes:
> >>
> >>>>> This appears to have been introduced in r36778.
> >>
> >>>>> Sample: http://sourceforge.net/p/mplayerwin/bugs/11/attachment/test.264
> >>
> >>>> The regression since r36778 is reproducible.
> >>
> >>> I'm not sure whether this patch is OK, but [...]
> >>
> >> I'm a lot surer about this patch. If the (negative) id doesn't change, there
> >> is no need to alter the stream header.
> 
> > The thing is that this just hides a bug and I am not sure that is a good
> > thing.
> > It should not be possible for sh to be non-null and the id not match the
> > stream index.
> 
> But it does so in the first place. Although stream 0 has been selected,
> demuxer->video->id is -1.

And I was trying to say that that is the real bug, and your changes
would just hide the issue.
I think it should be fixed now.