[MPlayer-dev-eng] Unable to detect/play H264-ES

[Reimar Döffinger]

On 19.02.2014, at 20:52, Ingo Brückl <ib at wupperonline.de> wrote:

> I wrote on Tue, 18 Feb 2014 14:14:09 +0100:
> 
>> Carl Eugen Hoyos wrote on Tue, 18 Feb 2014 11:58:38 +0000 (UTC):
> 
>>> Josh <joshf87 <at> live.com> writes:
> 
>>>> This appears to have been introduced in r36778.
> 
>>>> Sample: http://sourceforge.net/p/mplayerwin/bugs/11/attachment/test.264
> 
>>> The regression since r36778 is reproducible.
> 
>> I'm not sure whether this patch is OK, but [...]
> 
> I'm a lot surer about this patch. If the (negative) id doesn't change, there
> is no need to alter the stream header.

The thing is that this just hides a bug and I am not sure that is a good thing.
It should not be possible for sh to be non-null and the id not match the stream index.