[MPlayer-dev-eng] [PATCH] #define __BSD_VISIBLE to 1

[Alexander Strasser]

On 2014-02-16 18:38 +0100, Reimar Döffinger wrote:
> On Sun, Feb 16, 2014 at 06:16:14PM +0100, Alexander Strasser wrote:
> > +static void swap_bytes(uint8_t * buf, int size)
> > +{
> > +   uint16_t * p = (uint16_t *)buf;
> > +   size -= size & 1;
> > +   while (size > 0) {
> > +     *p = bswap_16(*p);
> > +     ++p;
> > +     size -= 2;
> > +   }
> 
> While that matches what swab does, I am not sure the odd size handling
> is actually correct for dnet.

  What should I do if the size is odd then?

> Also avoiding the cast and aliasing issues and using some AV_* macros
> might make sense.

  Will see what I can do.

Thanks for commenting,
  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140216/cf00fca2/attachment.asc>