[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

[Ingo Brückl]

Hans-Dieter Kosch wrote on Sat, 12 Apr 2014 02:13:21 +0200:

> Ingo Brückl wrote:

>> Well, and as soon as you try to change a simple feature you're meeting a
>> peck of troubles...
>>
>> When you click on a potmeter button to grab it, it would already move due
>> to its new value now. :-(

> No, yes, of course, that's exactly the pretty behaviour (IMO) :-)

For a rpotmeter yes, but I was talking about v/hpotmeters (with a button of
some heigth/width) - sorry for forgetting to mention it.

> 3) New (your revoked change): The value would jump already on press, and
> from there on smoothly follow the drag. This appears to me intuitive and
> much better than if it would jump surprisingly upon a drag ( 2) ).

I don't disagree, but in order to prevent a jumping v/hpotmeter button quite
some code changes seem necessary then (which certainly will lead immediately
to other necessary changes; and it would be useful to revise the ui/*.c code
before).

The point is, the X11/GTK GUI mouse handler (unlike the Win32 GUI's one)
doesn't know and doesn't care about the potmeter buttons. (There are pros
and cons either way.)

> So, I suggest: Stay with your change to move the action from release to
> press. It's really not trouble, it's an advance. Your last rpotmeter patch
> worked perfectly regarding that. And the code changes are minimal, I see no
> risk.

I'll post my patch after the rpotmeter commit. Get a skin with not too small
potmeter buttons (like Clearlooks) and try yourself. You may file a trac
feature request then, so that it won't pass out of mind.

> PS: Should you plan to do something during weekend,

Yes, my plans are: Release the pending rpotmeter stuff, update and release
skins that are using rotary potmeters and take a long (feature) break then
spending time with other things again. ;-)

Ingo