[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Hans-Dieter Kosch hdkosch at kabelbw.de
Thu Apr 10 04:11:19 CEST 2014


Ingo Brückl wrote:

>> 1. What delimiter / method should be used for the extra x0, y0, x1, y1?
> 
> Of all reasonable characters available for the current method (adding to
> default value), maybe the slash is the better choice?
> 
>   rpotmeter = NULL, 0, 0, volume, 51, 0/49/52/60/26, 189, 126, 61, 57, evSetVolume

That looks not bad. But why bind them to the default value and not really 
separate them by comma, they have logically nothing to do with the default. The 
syntax of the rpotmeter is different anyway, and the basics for syntax check are 
  now already layed out in the parsing. I'll try to prepare a suggestion.

Hans-Dieter


More information about the MPlayer-dev-eng mailing list