[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Ingo Brückl ib at wupperonline.de
Tue Apr 8 02:44:31 CEST 2014


Hans-Dieter Kosch wrote on Tue, 08 Apr 2014 01:08:47 +0200:

> It works :-)

I hope this here works even better.

It is (except for the documentation) the virtually complete patch for both
the X11/GTK and the Win32 GUI. I've tested extensively and it seems to do
what it should.

There are only two issues left:

1. What delimiter / method should be used for the extra x0, y0, x1, y1?

2. How can floating point and atan2 issues be overcome to determine whether
   two points x0,y0 and x1,y1 have virtually the same radian?

Although I'm going to review the patch by myself taking my time when being
well rested, I'd appreciate reviews, tests and reports if there are issues.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp.rpotmeter.rc2.patch
Type: text/x-diff
Size: 32567 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140408/640eead2/attachment-0001.bin>


More information about the MPlayer-dev-eng mailing list