[MPlayer-dev-eng] [PATCH 2/2] alsa: Better volume control handling, especially for S/PDIF.

[Ingo Brückl]

Reimar Döffinger wrote on Sun, 6 Apr 2014 17:52:12 +0200:

> On Sun, Apr 06, 2014 at 03:36:28PM +0200, Ingo Brückl wrote:
>> Reimar Döffinger wrote on Sat,  5 Apr 2014 14:53:03 +0200:
>>
>> > If no mixer channel was specified and PCM does not exist, just
>> > pick the first.
>> > If no volume control is available, at least support mute and full
>> > volume switching if a playback switch exists.
>> > This is also useful for being able to unmute S/PDIF devices.
>>
>> I can't detect any different behaviour here, but maybe I don't fulfil the
>> conditions.

> Well, if your device is unmuted from the start, the difference will be
> that a simple mute/unmute will not insert the volume filter.

I did not check this.

> (Though if you were to use a full soundcard with both spdif and
> normal output, you could have had any effect, e.g. it might have
> had working volume control or you might have gotten no volume control
> at all)

There is no spdif volume control for me with or without the patch (although
the volume bar is displayed when pressing 9 or 0 - but it's always a 0% bar).

> But if you (e.g. using alsamixer) mute the spdif device you should
> notice that there was no way to make it produce sound using MPlayer
> before.

I can't mute spdif with or without the patch. Although I'm getting the
information that the device is muted, it isn't. Unmuting updates the
information, but there is sound all the time - without any issues.

> Unfortunately I can't test it, but I also suspect that by moving the
> AC3 special-case for volume control this patch should also allow
> muting AC3 streams.

Not for me.

I just did some quick testing, if I can assist in doing more specific things,
please just tell.

Ingo