[MPlayer-dev-eng] [PATCH] ad_mpg123: runtime format switch and not closing stream during decodeh

[Thomas Orgis]

Am Mon, 23 Sep 2013 22:19:28 +0200
schrieb Reimar Döffinger <Reimar.Doeffinger at gmx.de>: 

> Sorry, this is not about formats.
> Does ffmp3 have issues with format changes? That would be a bug.
> I only meant sample rate.

Ah, beware of the terminology. With format I mean the whole audio
configuration: rate, channels, numerical encoding of pcm values.

> And even there it's not that one is more correct than the other,
> it's just that they work for different cases.
> And no, that's not reason to change it.

That's the important bit for me;-)

> That is overkill to have two .c files.
> You can just have two entries in /etc/codecs.conf both pointing to
> ad_mpg123.
> To distinguish them you can e.g. set the "dll" value which you can
> read from ad_mpg123 during init as sh_audio->codec->dll

That sounds fine. I'll see to a simple separate patch offering that choice.


Alrighty then,

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130923/5a8be166/attachment-0001.asc>