[MPlayer-dev-eng] [PATCH] Set default Blu-ray device
brad at comstyle.com
Mon May 13 06:01:24 CEST 2013
On Wed, May 08, 2013 at 10:32:47PM +0200, Reimar D?ffinger wrote:
> On Mon, May 06, 2013 at 01:43:49AM -0400, Brad Smith wrote:
> > On Mon, May 06, 2013 at 07:40:03AM +0200, Reimar D??ffinger wrote:
> > > On 05.05.2013, at 23:14, Brad Smith <brad at comstyle.com> wrote:
> > > > On Sun, May 05, 2013 at 07:10:12PM +0200, Reimar D?ffinger wrote:
> > > >> On Sun, May 05, 2013 at 12:41:54AM -0400, Brad Smith wrote:
> > > >>> Submitting a local patch from our OpenBSD ports tree to set
> > > >>> a default Blu-ray device.
> > > >>
> > > >> Since it's the same in all cases, why not just use DEFAULT_DVD_DEVICE?
> > > >
> > > > You mean within stream_bluray.c?
> > >
> > > Yes.
> > I had considered that. I wasn't sure if that would be Ok and just thought
> > I would submit the slightly simplified diff that I did and see where it
> > goes from there.
> > How about this then?
> Silly question, but did you actually test this?
> Because it sure doesn't work for me.
> The "device" (named like that for consistency I guess) can't be a device
> name, it must be the mounted path.
> If the decryption key is know, the files can reside on whichever media or file
> system desired, it's not such a mess as DVDs are.
To be honest I am just pushing the diff upstream as it was commited
to our ports tree. Another developer added the Blu-ray support to our
MPlayer port and I cannot confirm if the stream_bluray.c part of enabling
the Blu-ray support was tested or not. It made sense to me as I look at
VLC and Xine-lib and they appear to be able to access the device via
a device mount point instead of having to mount the disc and that IMO is
a more user friendly behavior.
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
More information about the MPlayer-dev-eng