[MPlayer-dev-eng] [PATCH] Set default Blu-ray device

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon May 6 23:48:06 CEST 2013



On 06.05.2013, at 07:43, Brad Smith <brad at comstyle.com> wrote:

> On Mon, May 06, 2013 at 07:40:03AM +0200, Reimar D??ffinger wrote:
>> On 05.05.2013, at 23:14, Brad Smith <brad at comstyle.com> wrote:
>>> On Sun, May 05, 2013 at 07:10:12PM +0200, Reimar D?ffinger wrote:
>>>> On Sun, May 05, 2013 at 12:41:54AM -0400, Brad Smith wrote:
>>>>> Submitting a local patch from our OpenBSD ports tree to set
>>>>> a default Blu-ray device.
>>>> 
>>>> Since it's the same in all cases, why not just use DEFAULT_DVD_DEVICE?
>>> 
>>> You mean within stream_bluray.c?
>> 
>> Yes.
> 
> I had considered that. I wasn't sure if that would be Ok and just thought
> I would submit the slightly simplified diff that I did and see where it
> goes from there.
> 
> How about this then?

If that works for you I think it's better.
I'll probably look a bit into it myself, I believe the error message for example should be unreachable now, so there might be a few things to simplify.
Also I wonder what stream_br currently uses by default.


More information about the MPlayer-dev-eng mailing list