[MPlayer-dev-eng] [PATCH] Add giflib 5 support

[Andïï]

On May 4, 2013 7:34 AM, "Reimar Döffinger" <Reimar.Doeffinger at gmx.de> wrote:
>
>
>
> On 02.05.2013, at 11:50, Andrew John Hughes <gnu_andrew at member.fsf.org>
wrote:
>
> > Trying again...
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2013-April/071595.html
> >
> > The attached patch allows mplayer to be built with giflib 5.  Tested
> > against 1.1 and SVN.
>
> Sorry, I forgot to ask a few things.
> I was wondering if there is much "need" for it, since FFmpeg does support
gif quite fully I think. Basically I am curious why you care :-)

If giflib has been upgraded to version 5, mplayer won't even detect the
presence of giflib and support won't be compiled. The patch fixes configure
to detect version 5 too, and the consequent build errors from code.

> This is related to whether there is much of a point in keeping support
for the old version.

Support for <5 needs to be kept for those who haven't yet upgraded.

FYI, I've had to patch quite a few other apps & libs too, including
IcedTea/OpenJDK where I'm maintainer.  Mplayer's fix is the most
complicated of the ones I've seen but it's along the same lines (mainly due
to non-standard configure).

> I also think if we want to keep support for the old version it might look
nicer if done via #defines (e.g. throwing away extra parameters is one
single trivial line of code like that).
> If I saw right you also added some extra error checking, it would be kind
of nice to have that as a separate patch.

I need to look over the patch again as it's a while now since I wrote it.
I'm surprised no-one else has encountered this yet, though it could be
missed if you don't check the results of configure (gif support just won't
be built).

> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng