[MPlayer-dev-eng] [PATCH] configure: Add a note about ffmpeg download

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Mar 30 09:48:54 CET 2013


On Sat, Mar 30, 2013 at 12:28:27AM +0100, Hans-Dieter Kosch wrote:
> Hi,
> 
> when running 'configure', messages from 'git' concerning 'ffmpeg' appear out of 
> sudden; it would be nice to have a hint for the user about what's going on. 
> Please see attached patch.
> 
> Hans-Dieter

> Index: configure
> ===================================================================
> --- configure	(revision 36097)
> +++ configure	(working copy)
> @@ -1490,6 +1490,8 @@
>  echo >> "$TMPLOG"
>  
>  
> +echo; echo "Getting FFmpeg..."; echo
> +
>  # local FFmpeg checkout handling
>  if test -e ffmpeg/.svn ; then
>      echo "You have an outdated FFmpeg SVN checkout in ffmpeg/, please (re)move or replace it"

That's the wrong place, it would print the message also in cases where
nothing will be downloaded.
Also, there is a more explicit question for the initial checkout.
Maybe something like this instead:
Index: configure
===================================================================
--- configure   (revision 36098)
+++ configure   (working copy)
@@ -1497,6 +1497,7 @@
 fi
 
 if test -e ffmpeg/mp_auto_pull ; then
+    echo "Updating FFmpeg, (re)move ffmpeg/mp_auto_pull to disable"
     (cd ffmpeg && git checkout master)
     if ! (cd ffmpeg && git pull --rebase --ff-only) ; then
         echo "git pull failed, (re)move ffmpeg/mp_auto_pull to disable pulling"


More information about the MPlayer-dev-eng mailing list