[MPlayer-dev-eng] [PATCH] Better double frame rate output and frame limit option.

[Vicente Sendra]

--- El sáb, 2/3/13, Carl Eugen Hoyos <cehoyos at ag.or.at> escribió:

> De: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Asunto: Re: [MPlayer-dev-eng] [PATCH] Better double frame rate output and frame limit option.
> Para: mplayer-dev-eng at mplayerhq.hu
> Fecha: sábado, 2 de marzo, 2013 15:06
> Vicente Sendra <visenri <at>
> yahoo.es> writes:
> 
> > Finally, i finished all my test for the new system.
> 
> Your patchset makes MPlayer very verbose by default: 
> Is that intended? Or is this only meant as a version 
> to test?

I did it this way, to get some debug information/feedback
from other developers (in previous mails i pointed what parts
could be commented/deleted), if you want i can send you a clean
version, but i think you should check this version with your
patches before deleting debug information.

> Generally, please produce your patch with 
> "svn di >patchfile" your current set is very difficult 
> to apply.

Until now, I used winmerge to generate my patches, may be the problem is that my patches are done over r35689, i'll try to update my patches to
current svn snapshot 35927.

Can you describe more precisely the problem?

 
> Does mode 0 imply identical behaviour to current 
> svn or is there anything different? 


Yes, and no, some changes still apply, I'll explain it by parts:

> ////////////////////////////////////////
>     New fpslimit option
> ////////////////////////////////////////

It disables frame rate limit completely, so, in this aspect it behaves as vanilla code.

> ////////////////////////////////////////
>     New framedrop logic
> ////////////////////////////////////////
>  
> -Works even with no sound.
> -Drops frames by sync or fpslimit.
> -Works for all frames, read and interpolated (created by
> vf)

Here, when you disable fpslimit, frame dropping by fpslimit is disabled, but the other changes are still working (so, this behavior changed from vanilla code).

To be clear, in vanilla code, framedropping:

-Didn't work with no sound.
-Dropped frames only by sync.
-Worked only for read frames, interpolated frames were never dropped.

with my patches and fpslimit mode set to 0, framedropping:

-Works even with no sound.
-Drops frames only by sync.
-Works for all frames, read and interpolated (created by vf).


> ////////////////////////////////////////
>     New double frame rate output
> ////////////////////////////////////////

New double frame rate behavior is not affected by this option, frames are now always queued and timed by mplayer main loop (as it was previously only done in correctpts mode), resulting in correct timing for them (so, this behavior changed from vanilla code).

May be you have been confused because i said "normal mode" in the description of the "New double frame rate output", this mode has nothing to do with fpslimit mode. It just means the opposite of correct-pts mode, that means variable "correct_pts" is equal to 0.