[MPlayer-dev-eng] [PATCH] Fix FOURCC check in mplayer.c

Hans-Dieter Kosch hdkosch at kabelbw.de
Sat Jun 15 22:51:25 CEST 2013


the expressions in mplayer.c to check for FOURCC format

/* Assume FOURCC if all bytes >= 0x20 (' ') */
if (mpctx->sh_{video,audio}->format >= 0x20202020)

are also True if a MSB is > 0x20 while a LSB is < 0x20 (e.g. 0x2020211F), what's 
not intended.

Attached a patch which checks byte by byte.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fourcc_mplayer.c.patch
Type: text/x-patch
Size: 1657 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130615/a8ec1c61/attachment.bin>

More information about the MPlayer-dev-eng mailing list