[MPlayer-dev-eng] [PATCH] Check if path is too long

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Jun 15 16:22:44 CEST 2013



On 15.06.2013, at 07:40, KO Myung-Hun <komh78 at gmail.com> wrote:

> 
> 
> KO Myung-Hun wrote:
>> 
>> 
>> Reimar Döffinger wrote:
>>> On 13.06.2013, at 03:27, KO Myung-Hun <komh78 at gmail.com> wrote:
>>>> New patch attached.
>>> 
>>> Interesting.
>>> But you don't need to include the headers for open(), opendir(), fopen() since they will already be included by the files using these (and for macros the functions do not need to be known where the macro is declared, only where it is used).
>> 
>> The result is this if the headers are removed,
>> 
>> -----
>> gcc -MMD -MP -W -Wall  -D_ISOC99_SOURCE -I. -Iffmpeg -O2 -march=i486
>> -mtune=generic -pipe -g  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
>> -D_LARGEFILE64_SOURCE -Ilibdvdread4   -I/usr/include/freetype2 -c -o
>> stream/stream_vcd.o stream/stream_vcd.c
>> In file included from stream/stream.h:26,
>>                 from stream/stream_vcd.c:28:
>> f:/lang/gcc/usr/include/stdio.h:280: error: expected ')' before '>=' token
>> In file included from f:/lang/gcc/usr/include/fcntl.h:10,
>>                 from stream/stream.h:30,
>>                 from stream/stream_vcd.c:28:
>> f:/lang/gcc/usr/include/sys/fcntl.h:265: error: expected ')' before '>='
>> token
>> In file included from stream/stream_vcd.c:48:
>> stream/vcd_read_os2.h: In function 'vcd_seek_to_track':
>> stream/vcd_read_os2.h:65: warning: missing initializer
>> stream/vcd_read_os2.h:65: warning: (near initialization for 'sParam.bTrack')
>> stream/vcd_read_os2.h: In function 'vcd_read_toc':
>> stream/vcd_read_os2.h:115: warning: missing initializer
>> stream/vcd_read_os2.h:115: warning: (near initialization for
>> 'sParamTrack.bTrack')
>> stream/vcd_read_os2.h: In function 'vcd_read':
>> stream/vcd_read_os2.h:205: warning: missing initializer
>> stream/vcd_read_os2.h:205: warning: (near initialization for
>> 'sParam.msfStart')
>> stream/stream_vcd.c: In function 'fill_buffer':
>> stream/stream_vcd.c:80: warning: unused parameter 'max_len'
>> stream/stream_vcd.c: In function 'open_s':
>> stream/stream_vcd.c:176: warning: pointer targets in passing argument 1
>> of 'DosOpen' differ in signedness
>> f:/lang/gcc/usr/include/os2emx.h:1941: note: expected 'PCSZ' but
>> argument is of type 'char *'
>> stream/stream_vcd.c:177: warning: signed and unsigned type in
>> conditional expression
>> make.exe: *** [stream/stream_vcd.o] Error 1
>> -----
>> 
> 
> No more comments ?

Nothing from me at least.


More information about the MPlayer-dev-eng mailing list