[MPlayer-dev-eng] [PATCH] Check if path is too long
Reimar.Doeffinger at gmx.de
Mon Jun 10 20:10:49 CEST 2013
On 10.06.2013, at 16:59, KO Myung-Hun <komh78 at gmail.com> wrote:
> KO Myung-Hun wrote:
> I'll commit this tomorrow if no more comments...
I think it's quite fine in principle, but some minor nits:
I think it might be nicer to just put it all into a single header.
Next, I think you should be using macros with parameters, to avoid replacing e.g. variables. Though I admit this is a bit problematic since it means the replacement won't work if "open" was assigned to a function pointer.
On the other hand it might allow implementing both open() variants without having to resort to varargs, which has different behaviour from the non-varargs variant in the specification (using varargs means that e.g. a float value would be passed as such instead of being converted to the specified mode_t type).
I.e. something like
#define open(a, b) mplayer_open(a, b, 0)
Which leads me to the last point: you seem to implement an open variant with 4 arguments, but there is only the 2 and 3 argument one (and only the 3 argument one seems to be actually used in MPlayer).
More information about the MPlayer-dev-eng