[MPlayer-dev-eng] [PATCH] Check if path is too long

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Jun 6 17:31:00 CEST 2013

On 06.06.2013, at 16:16, KO Myung-Hun <komh78 at gmail.com> wrote:
> Reimar Döffinger wrote:
>> On 05.06.2013, at 15:35, KO Myung-Hun <komh78 at gmail.com> wrote
>> The other is that it follows the rule of "keep the hack close to the broken code"
> I don't know that the rule is there. And I agree with it in the normal
> case. But if the root of causes are found, fixing it is better.

Well, I doubt you'll be able to fix the C library?
Btw. a backtrace of the error would be useful, any fix should include an exact description of the issue.

> Otherwise, this would be burden to a developer, because, similarly
> above, a developer have to add the hack keeping track of all the broken
> codes.

That isn't any better with your solution, if all file access functions crash, your change addresses only a select few of all the places that cause issues.
Overriding e.g. open() to use our own implementation in some header would have a chance to fix most.

More information about the MPlayer-dev-eng mailing list