[MPlayer-dev-eng] [PATCH] ao_jack: add "connect" suboption

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jun 3 19:38:57 CEST 2013


On Sat, Jun 01, 2013 at 05:23:18PM +0200, Markus Appel wrote:
> On 05/27/2013 10:39 PM, Reimar Döffinger wrote:
> >>@@ -241,20 +245,23 @@
> >>    buffer = av_fifo_alloc(BUFFSIZE);
> >>    jack_set_process_callback(client, outputaudio, 0);
> >>
> >>-  // list matching ports
> >>-  if (!port_name)
> >>-    port_flags |= JackPortIsPhysical;
> >>-  matching_ports = jack_get_ports(client, port_name, NULL, port_flags);
> >>-  i = 0;
> >>-  while (matching_ports && matching_ports[i]) i++;
> >>-  if (!i) {
> >>-    mp_msg(MSGT_AO, MSGL_FATAL, "[JACK] no physical ports available\n");
> >>-    goto err_out;
> >>+  // list matching ports if connections should be made
> >>+  if (connect) {
> >
> >Trailing whitespace.
> 
> Oops. Sorry.

There was some more in the man page parts.
Anyway, patch committed, thanks for your patience.


More information about the MPlayer-dev-eng mailing list