[MPlayer-dev-eng] [PATCH] GUI: Once more aspect ratio

[Ingo Brückl]

Hans-Dieter Kosch wrote on Sun, 28 Jul 2013 19:17:32 +0200:

> Ingo Brückl wrote:
>> Hans-Dieter Kosch wrote on Wed, 17 Jul 2013 01:59:09 +0200:
>>
>>> attached some patches on the recent revision of aspect ratio selection.
>>
>> Applied, except for resetting the aspect ratio with new playback (still
>> thinking about the best way to do it).
>>
> Thanks!
> Regarding resetting: I intended consistency. 'gui/win32/interface.c' resets
> to original aspect, but 'gui/interface.c' does not.

Agreed. Pure MPlayer - already - resets, too, so the X11/GTK GUI should do as
well (but without patching command.c).

> if explicit aspect is selected, it is retained across the streams.

Only with the X11/GTK GUI.

>> BTW, there are a few other settings that possibly should be reset (like
>> audio delay, subtitle delay etc.?)
>>
> My idea is: If the user does corrective settings on a stream, they should
> be reset upon the next; if he does preference settings, they should be
> retained. But may be not so easy to decide...

Yes, indeed.

Ingo