[MPlayer-dev-eng] [PATCH] Support newer GIFLIB versions

Alexander Strasser eclipse7 at gmx.net
Mon Jul 22 18:40:53 CEST 2013


On 2013-07-22 13:06 +0000, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> 
> > Alexander Strasser <eclipse7 <at> gmx.net> writes:
> > 
> > >    for ld_gif in "-lungif" "-lgif" ; do
> > >      statement_check gif_lib.h 
> > > 'QuantizeBuffer(0, 0, 0, 0, 0, 0, 0, 0)' $ld_gif && 
> > > _gif=yes && break
> > > +    statement_check gif_lib.h 
> > > 'GifQuantizeBuffer(0, 0, 0, 0, 0, 0, 0, 0)' $ld_gif && 
> > > _gif=yes && break
> > 
> > Why is this needed?
> > Breaks giflib detection here.
> 
> To clarify:
> If no backwards compatibility is needed (it is not needed 
> imo) then the rest of the patch could be simplified.

  IMO in the case of our modules that use GIFLIB I do *not*
suspect them to be changed very often in the future. That
is why I thought backwards compatibility would be nice and
why I tried to retain it.

  Coherently I have missed some previous discussion, but
I would like to keep backward compatibility for now. If
future GIFLIB changes would complicate matters we could
drop it easily enough.

  I will looko into the old arguments now.

  Alexander


More information about the MPlayer-dev-eng mailing list